linux-kernel - Re: [PATCH 2/2] iio:adc:at91-sama5d2: code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 23 Jan 2016 16:17:22 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Ludovic Desroches <ludovic.desroches@...el.com>,
	nicolas.ferre@...el.com
Cc:	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] iio:adc:at91-sama5d2: code cleanup

On 18/01/16 08:41, Ludovic Desroches wrote:
> Use var type for sizeof argument instead of the struct name.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@...el.com>
Applied, thanks.

Jonathan
> ---
>  drivers/iio/adc/at91-sama5d2_adc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index f2d8bd5..dbee13a 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -353,8 +353,7 @@ static int at91_adc_probe(struct platform_device *pdev)
>  	struct resource	*res;
>  	int ret;
>  
> -	indio_dev = devm_iio_device_alloc(&pdev->dev,
> -					  sizeof(struct at91_adc_state));
> +	indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*st));
>  	if (!indio_dev)
>  		return -ENOMEM;
>  
>