linux-kernel - Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into printout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160123161958.GA30110@krava.local>
Date:	Sat, 23 Jan 2016 17:19:58 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	acme@...nel.org, jolsa@...nel.org, mingo@...nel.org,
	linux-kernel@...r.kernel.org, eranian@...gle.com,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into
 printout

On Sat, Jan 23, 2016 at 04:43:05AM +0100, Andi Kleen wrote:
> > > -		if (run == 0 || ena == 0) {
> > > -			fprintf(output, "CPU%*d%s%*s%s",
> > > -				csv_output ? 0 : -4,
> > > -				perf_evsel__cpus(counter)->map[cpu], csv_sep,
> > > -				csv_output ? 0 : 18,
> > > -				counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED,
> > > -				csv_sep);
> > 
> > this hunk is not preserved in the new code.. I guess the output is
> > different for -A if counter wasn't meassure?
> 
> The code for this is common in printout() now.

but what will be printed for -A not counted counters?
not the "CPU%*d%s%*s%s" ...

jirka