linux-kernel - Re: [PATCH v1] block: fix bio splitting on max sectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A2F70E.2070802@kernel.dk>
Date:	Fri, 22 Jan 2016 20:44:14 -0700
From:	Jens Axboe <axboe@...nel.dk>
To:	Ming Lei <tom.leiming@...il.com>, linux-kernel@...r.kernel.org
Cc:	linux-block@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Stefan Haberland <sth@...ux.vnet.ibm.com>,
	Keith Busch <keith.busch@...el.com>
Subject: Re: [PATCH v1] block: fix bio splitting on max sectors

On 01/22/2016 05:05 PM, Ming Lei wrote:
> After commit e36f62042880(block: split bios to maxpossible length),
> bio can be splitted in the middle of a vector entry, then it
> is easy to split out one bio which size isn't aligned with block
> size, especially when the block size is bigger than 512.
>
> This patch fixes the issue by making the max io size aligned
> to logical block size.
>
> Fixes: e36f62042880(block: split bios to maxpossible length)
> Reported-by: Stefan Haberland <sth@...ux.vnet.ibm.com>
> Cc: Keith Busch <keith.busch@...el.com>
> Suggested-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Ming Lei <tom.leiming@...il.com>
> ---
> V1:
> 	- avoid double shift as suggested by Linus
> 	- compute 'max_sectors' once as suggested by Keith

This looks good to me, I'll apply and run a bit of local testing.

-- 
Jens Axboe