linux-kernel - Re: [PATCH v1] block: fix bio splitting on max sectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A62DA7.8050506@linux.vnet.ibm.com>
Date:	Mon, 25 Jan 2016 15:13:59 +0100
From:	Stefan Haberland <sth@...ux.vnet.ibm.com>
To:	Jens Axboe <axboe@...nel.dk>, Ming Lei <tom.leiming@...il.com>,
	linux-kernel@...r.kernel.org
Cc:	linux-block@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Keith Busch <keith.busch@...el.com>
Subject: Re: [PATCH v1] block: fix bio splitting on max sectors

Am 23.01.2016 um 04:44 schrieb Jens Axboe:
> On 01/22/2016 05:05 PM, Ming Lei wrote:
>> After commit e36f62042880(block: split bios to maxpossible length),
>> bio can be splitted in the middle of a vector entry, then it
>> is easy to split out one bio which size isn't aligned with block
>> size, especially when the block size is bigger than 512.
>>
>> This patch fixes the issue by making the max io size aligned
>> to logical block size.
>>
>> Fixes: e36f62042880(block: split bios to maxpossible length)
>> Reported-by: Stefan Haberland <sth@...ux.vnet.ibm.com>
>> Cc: Keith Busch <keith.busch@...el.com>
>> Suggested-by: Linus Torvalds <torvalds@...ux-foundation.org>
>> Signed-off-by: Ming Lei <tom.leiming@...il.com>
>> ---
>> V1:
>>     - avoid double shift as suggested by Linus
>>     - compute 'max_sectors' once as suggested by Keith
>
> This looks good to me, I'll apply and run a bit of local testing.
>

I applied the patch and it seems to work for DASD devices. I will do 
some more testing but for me it looks OK.
Thanks!

Regards,
Stefan