linux-kernel - Re: [PATCHSET 0/7] perf tools: Check error during collapsing hist entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160124043755.GA6846@danjae.kornet>
Date:	Sun, 24 Jan 2016 13:37:55 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCHSET 0/7] perf tools: Check error during collapsing hist
 entries

On Sat, Jan 23, 2016 at 06:01:21PM +0100, Jiri Olsa wrote:
> On Fri, Jan 22, 2016 at 10:41:33PM +0900, Namhyung Kim wrote:
> > Hi,
> > 
> > This patchset checks error case during the process of collapsing hist
> > entries.  It's a preparation of upcoming hierarchy patchset which adds
> > more work in the collapsing path.  If there's an error during this
> > stage, it'll stop processing and show warning to user.
> > 
> > Thanks,
> > Namhyung
> > 
> > 
> > Namhyung Kim (7):
> >   perf callchain: Check return value of add_child()
> >   perf callchain: Check return value of fill_node()
> >   perf callchain: Add enum match_result for match_chain()
> >   perf callchain: Check return value of split_add_child()
> >   perf callchain: Check return value of append_chain_children()
> >   perf hists: Return error from hists__collapse_resort()
> >   perf report: Check error during report__collapse_hists()
> 
> I saw 2 other functions allocating memory and not checked:
>   callchain_cursor_append

Ok, but this function is basically for the 'addition' path.  Well it's
also used by the 'collapsing' path but it never allocates new node
since it reuses the existing ones.  I'll prepare a different patchset
for the 'addition' path later..


>   callchain_node__make_parent_list

It seems not called in the collapsing path.  It should be handled by
a separate patchset.

Thanks,
Namhyung