linux-kernel - Re: [PATCH] GPU-host1x: Use a signed return type for do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160125140505.GC7014@ulmo.nvidia.com>
Date:	Mon, 25 Jan 2016 15:05:05 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	linux-tegra@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	Terje Bergström <tbergstrom@...dia.com>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] GPU-host1x: Use a signed return type for do_relocs()

On Sat, Dec 19, 2015 at 12:56:54PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 19 Dec 2015 12:48:31 +0100
> 
> The return type "unsigned int" was used by the do_relocs() function
> despite of the aspect that it will eventually return a negative error code.
> Improve this implementation detail by deletion of the type qualifier then.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/gpu/host1x/job.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Good catch. Applied, thanks.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)