linux-kernel - Re: [RFC 00/26] perf tools: Introduce hists specific format entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jan 2016 23:24:24 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Jiri Olsa <jolsa@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [RFC 00/26] perf tools: Introduce hists specific format entries

Hi Jiri,

On Mon, Jan 25, 2016 at 08:15:52AM +0100, Jiri Olsa wrote:
> On Mon, Jan 18, 2016 at 10:23:58AM +0100, Jiri Olsa wrote:
> > hi,
> > currently we have global format sort and output
> > lists. This rfc patchset introduces hists object
> > based format entries to allow the hist object to
> > carry specific format entries.
> > 
> > This will allow to have distinguished hist objects
> > displaying different stuff in output.

The concepth is OK.  But I don't want to embed hists into the
hist_entry for hierarchy mode.  As you said it'd be better to factor
out common bits and embed it both from hists and hist entry.  In the
minimal, two rbroot (for in and out) and a format list would be
required IMHO.

Thanks,
Namhyung