linux-kernel - Re: [RFC PATCH] PPC32: Fix build failure caused by missing dirty pte handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1453778024.24248.4.camel@ellerman.id.au>
Date:	Tue, 26 Jan 2016 14:13:44 +1100
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Pranith Kumar <bobby.prani@...il.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	"open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" 
	<linuxppc-dev@...ts.ozlabs.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] PPC32: Fix build failure caused by missing dirty
 pte handlers

On Mon, 2016-01-25 at 09:22 -0500, Pranith Kumar wrote:

> In 4.5-rc1, I am getting a build failure as follows:
> 
> mm/memory.c: In function ‘do_swap_page’:
> mm/memory.c:2573:9: error: implicit declaration of function ‘pte_mksoft_dirty’
> [-Werror=implicit-function-declaration]
>    pte = pte_mksoft_dirty(pte);
> 
> The soft dirty pte handlers are declared only for PPC64 on PPC_BOOK3S in
> arch/powerpc/include/asm/book3s/64/hash.h and missing in the 32-bit arch.
> 
> Avoid this error by not setting HAVE_ARCH_SOFT_DIRTY for 32-bit system.

It's building for me, what config are you using?

http://kisskb.ellerman.id.au/kisskb/buildresult/12597204/

cheers