[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <56A8CD2F.5080903@suse.cz>
Date: Wed, 27 Jan 2016 14:59:11 +0100
From: Vlastimil Babka <vbabka@...e.cz>
To: Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
Andrew Morton <akpm@...ux-foundation.org>
Cc: Chen Gong <gong.chen@...ux.intel.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org,
Naoya Horiguchi <nao.horiguchi@...il.com>,
Linux API <linux-api@...r.kernel.org>,
linux-man@...r.kernel.org, Michael Kerrisk <mtk.manpages@...il.com>
Subject: Re: [PATCH v1] mm/madvise: pass return code of memory_failure() to
userspace
[CC += linux-api, linux-man]
On 01/22/2016 09:27 AM, Naoya Horiguchi wrote:
> Currently the return value of memory_failure() is not passed to userspace, which
> is inconvenient for test programs that want to know the result of error handling.
> So let's return it to the caller as we already do in MADV_SOFT_OFFLINE case.
>
> Signed-off-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
> ---
> mm/madvise.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git v4.4-mmotm-2016-01-20-16-10/mm/madvise.c v4.4-mmotm-2016-01-20-16-10_patched/mm/madvise.c
> index f56825b..6a77114 100644
> --- v4.4-mmotm-2016-01-20-16-10/mm/madvise.c
> +++ v4.4-mmotm-2016-01-20-16-10_patched/mm/madvise.c
> @@ -555,8 +555,9 @@ static int madvise_hwpoison(int bhv, unsigned long start, unsigned long end)
> }
> pr_info("Injecting memory failure for page %#lx at %#lx\n",
> page_to_pfn(p), start);
> - /* Ignore return value for now */
> - memory_failure(page_to_pfn(p), 0, MF_COUNT_INCREASED);
> + ret = memory_failure(page_to_pfn(p), 0, MF_COUNT_INCREASED);
> + if (ret)
> + return ret;
Can you explain what madvise can newly return for MADV_HWPOISON in which
situations, for the purposes of updated man page?
Thanks,
Vlastimil
> }
> return 0;
> }
>
Powered by blists - more mailing lists