[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACRpkdb6-GhWdZ=0gM5YnpL6GzBmoUX1dLWCUDhCw+VgLxpLzg@mail.gmail.com>
Date: Wed, 27 Jan 2016 15:00:19 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Paul Gortmaker <paul.gortmaker@...driver.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Daniel Kurtz <djkurtz@...omium.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Hongzhou Yang <hongzhou.yang@...iatek.com>,
Yingjoe Chen <yingjoe.chen@...iatek.com>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] drivers/pinctrl: make mediatek/pinctrl-mt8* driver
explicitly non-modular
On Mon, Jan 4, 2016 at 6:44 PM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:
> The Kconfig for these drivers are currently:
>
> config PINCTRL_MT8127
> bool "Mediatek MT8127 pin control" if COMPILE_TEST && !MACH_MT8127
>
> config PINCTRL_MT8135
> bool "Mediatek MT8135 pin control" if COMPILE_TEST && !MACH_MT8135
>
> config PINCTRL_MT8173
> bool "Mediatek MT8173 pin control"
>
> ...meaning that they are currently not being built as a module by anyone.
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> A recent commit moved these from module_init to arch_initcall already, so
> the init ordering remains untouched with this commit.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Daniel Kurtz <djkurtz@...omium.org>
> Cc: Matthias Brugger <matthias.bgg@...il.com>
> Cc: Hongzhou Yang <hongzhou.yang@...iatek.com>
> Cc: Yingjoe Chen <yingjoe.chen@...iatek.com>
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-mediatek@...ts.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
Patch applied.
Sorry for delayed response...
Yours,
Linus Walleij
Powered by blists - more mailing lists