linux-kernel - Re: [PATCH] mmc: sdhci-iproc: use sdhci_pltfm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A824BF.3030202@broadcom.com>
Date:	Tue, 26 Jan 2016 18:00:31 -0800
From:	Scott Branden <sbranden@...adcom.com>
To:	Jisheng Zhang <jszhang@...vell.com>, <ulf.hansson@...aro.org>,
	<rjui@...adcom.com>, <jonmason@...adcom.com>
CC:	<linux-mmc@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<bcm-kernel-feedback-list@...adcom.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-iproc: use sdhci_pltfm_unregister directly

Hi Jisheng,

Looks good.

Acked-by: Scott Branden <sbranden@...adcom.com>

On 16-01-26 02:26 AM, Jisheng Zhang wrote:
> The sdhci_iproc_remove() is jsut a wrapper to sdhci_pltfm_unregister.
> So use the sdhci_pltfm_unregister() for the .remove hook directly.
>
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
> ---
>   drivers/mmc/host/sdhci-iproc.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 3b423b0..24c5546 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -220,11 +220,6 @@ err:
>   	return ret;
>   }
>
> -static int sdhci_iproc_remove(struct platform_device *pdev)
> -{
> -	return sdhci_pltfm_unregister(pdev);
> -}
> -
>   static struct platform_driver sdhci_iproc_driver = {
>   	.driver = {
>   		.name = "sdhci-iproc",
> @@ -232,7 +227,7 @@ static struct platform_driver sdhci_iproc_driver = {
>   		.pm = SDHCI_PLTFM_PMOPS,
>   	},
>   	.probe = sdhci_iproc_probe,
> -	.remove = sdhci_iproc_remove,
> +	.remove = sdhci_pltfm_unregister,
>   };
>   module_platform_driver(sdhci_iproc_driver);
>
>