linux-kernel - Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160127170313.GC3773@joana>
Date:	Wed, 27 Jan 2016 15:03:13 -0200
From:	Gustavo Padovan <gustavo@...ovan.org>
To:	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	dri-devel@...ts.freedesktop.org,
	Daniel Stone <daniels@...labora.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	Riley Andrews <riandrews@...roid.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Rob Clark <robdclark@...il.com>,
	Greg Hackmann <ghackmann@...gle.com>,
	John Harrison <John.C.Harrison@...el.com>,
	Gustavo Padovan <gustavo.padovan@...labora.co.uk>
Subject: Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file

Hi Maarten,

2016-01-27 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>:

> Hey,
> 
> Op 27-01-16 om 14:30 schreef Gustavo Padovan:
> > From: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
> >
> > sync_file is useful to connect one or more fences to the file. The file is
> > used by userspace to track fences.
> >
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
> >
> Is there a value in keeping the abi unchanged?
> If not, then Documentation/ioctl/botching-up-ioctls.txt is worth a read.

None from me. I'll look where we can improve the ABI.

> 
> Looking at the patch, it seems you kept SYNC_IOC_WAIT, won't it be better to remove it, and only support waiting with polling?
> The code for polling should already work.

Sure, that makes sense for me.

> 
> It's very unclear what format @driver_data has. I kept it for compatibility with android, but it's not clear to me how a userspace consumer would print it.
> Is there a usecase for this, or could it be removed from fence and sync_file?

I don't have any usecase for this. I'd say we remove it for now and if
someone needs this in the future we can talk about this again.

	Gustavo