linux-kernel - Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Jan 2016 18:17:14 +0000
From:	Emil Velikov <emil.l.velikov@...il.com>
To:	Gustavo Padovan <gustavo@...ovan.org>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org,
	ML dri-devel <dri-devel@...ts.freedesktop.org>,
	Daniel Stone <daniels@...labora.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	Riley Andrews <riandrews@...roid.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Rob Clark <robdclark@...il.com>,
	Greg Hackmann <ghackmann@...gle.com>,
	John Harrison <John.C.Harrison@...el.com>,
	Gustavo Padovan <gustavo.padovan@...labora.co.uk>
Subject: Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file

Hi Gustavo,

On 27 January 2016 at 17:03, Gustavo Padovan <gustavo@...ovan.org> wrote:
> Hi Maarten,
>
> 2016-01-27 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>:
>
>> Hey,
>>
>> Op 27-01-16 om 14:30 schreef Gustavo Padovan:
>> > From: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
>> >
>> > sync_file is useful to connect one or more fences to the file. The file is
>> > used by userspace to track fences.
>> >
>> > Signed-off-by: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
>> >
>> Is there a value in keeping the abi unchanged?
>> If not, then Documentation/ioctl/botching-up-ioctls.txt is worth a read.
>
> None from me. I'll look where we can improve the ABI.
>
Speaking of ABI... there are a couple of things that rang bells here:
 - In most/all of the kernel a len/size named member variable
indicates the length of the extra data (zero sized array). While here
it includes the size of the struct as well.
 - struct sync_file_info_data::fence_info is of type __u8 yet it is "a
fence_info struct for every fence in the sync_file". Thus shouldn't
one use "struct fence_info" as the type ?

-Emil