linux-kernel - Re: [PATCH] kexec: unmap reserved pages for each error-return way

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160127111546.2212f191f5f313b613f6b60b@linux-foundation.org>
Date:	Wed, 27 Jan 2016 11:15:46 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Dmitry Safonov <dsafonov@...tuozzo.com>
Cc:	<linux-kernel@...r.kernel.org>, <schwidefsky@...ibm.com>,
	<heiko.carstens@...ibm.com>, <ebiederm@...ssion.com>,
	<kexec@...ts.infradead.org>, <linux-s390@...r.kernel.org>,
	<holzheu@...ux.vnet.ibm.com>, <dyoung@...hat.com>,
	<0x7f454c46@...il.com>, Xunlei Pang <xlpang@...hat.com>
Subject: Re: [PATCH] kexec: unmap reserved pages for each error-return way

On Wed, 27 Jan 2016 14:48:31 +0300 Dmitry Safonov <dsafonov@...tuozzo.com> wrote:

> For allocation of kimage failure or kexec_prepare or load segments
> errors there is no need to keep crashkernel memory mapped.
> It will affect only s390 as map/unmap hook defined only for it.
> As on unmap s390 also changes os_info structure let's check return code
> and add info only on success.
> 

This conflicts (both mechanically and somewhat conceptually) with
Xunlei Pang's "kexec: Introduce a protection mechanism for the
crashkernel reserved memory" and "kexec: provide
arch_kexec_protect(unprotect)_crashkres()".

http://ozlabs.org/~akpm/mmots/broken-out/kexec-introduce-a-protection-mechanism-for-the-crashkernel-reserved-memory.patch
http://ozlabs.org/~akpm/mmots/broken-out/kexec-introduce-a-protection-mechanism-for-the-crashkernel-reserved-memory-v4.patch

and

http://ozlabs.org/~akpm/mmots/broken-out/kexec-provide-arch_kexec_protectunprotect_crashkres.patch
http://ozlabs.org/~akpm/mmots/broken-out/kexec-provide-arch_kexec_protectunprotect_crashkres-v4.patch

so can we please sort all that out?