linux-kernel - [PATCH] PCI: iproc: Remove redundant function number check for PAXC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1454024240-12270-1-git-send-email-rjui@broadcom.com>
Date:	Thu, 28 Jan 2016 15:37:20 -0800
From:	Ray Jui <rjui@...adcom.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
CC:	Bjorn Helgaas <helgaas@...nel.org>,
	Rafal Milecki <zajec5@...il.com>,
	Hante Meuleman <meuleman@...adcom.com>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	<linux-kernel@...r.kernel.org>,
	<bcm-kernel-feedback-list@...adcom.com>,
	<linux-pci@...r.kernel.org>, Ray Jui <rjui@...adcom.com>
Subject: [PATCH] PCI: iproc: Remove redundant function number check for PAXC

This patch removes the conditional check that limits the number of
functions to be supported by the internally emulated endpoint device
connected to PAXC. Investigation shows that the emulated PAXC endpoint
device can properly reject request for unsupported functions, which
makes this conditional check redundant

Signed-off-by: Ray Jui <rjui@...adcom.com>
---
 drivers/pci/host/pcie-iproc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c
index 9ae43ed..b65185d 100644
--- a/drivers/pci/host/pcie-iproc.c
+++ b/drivers/pci/host/pcie-iproc.c
@@ -204,7 +204,7 @@ static void __iomem *iproc_pcie_map_cfg_bus(struct pci_bus *bus,
 	 * allows only one device and supports a limited number of functions.
 	 */
 	if (pcie->type == IPROC_PCIE_PAXC)
-		if (slot > 0 || fn >= MAX_NUM_PAXC_PF)
+		if (slot > 0)
 			return NULL;
 
 	/* EP device access */
-- 
1.9.1