linux-kernel - Re: [PATCH 15/15] Revert "of/platform: export of_default_bus_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Jan 2016 10:11:38 +0800
From:	Kefeng Wang <wangkefeng.wang@...wei.com>
To:	Hauke Mehrtens <hauke@...ke-m.de>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
CC:	Arnd Bergmann <arnd@...db.de>, Shawn Guo <shawnguo@...nel.org>,
	"Russell King" <linux@....linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	<guohanjun@...wei.com>, Frank Rowand <frowand.list@...il.com>,
	Grant Likely <grant.likely@...aro.org>
Subject: Re: [PATCH 15/15] Revert "of/platform: export
 of_default_bus_match_table"

Hi Hauke,

On 2016/1/28 6:10, Hauke Mehrtens wrote:
> On 01/27/2016 05:27 AM, Kefeng Wang wrote:
>> This reverts commit b80443c2211c7daaabd20fbbe9e7beb3fa3408e0.
>>
>> After covering to use helper of_platform_default_populate() to populate
>> the default bus, no need to export of_default_bus_match_table anymore.
>>
>> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
>> Cc: Rob Herring <robh+dt@...nel.org>
>> Cc: Frank Rowand <frowand.list@...il.com> 
>> Cc: Grant Likely <grant.likely@...aro.org>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
>> ---
>>  drivers/of/platform.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
>> index 8d103e4..af98343 100644
>> --- a/drivers/of/platform.c
>> +++ b/drivers/of/platform.c
>> @@ -31,7 +31,6 @@ const struct of_device_id of_default_bus_match_table[] = {
>>  #endif /* CONFIG_ARM_AMBA */
>>  	{} /* Empty terminated list */
>>  };
>> -EXPORT_SYMBOL(of_default_bus_match_table);
>>  
>>  static int of_dev_node_match(struct device *dev, void *data)
>>  {
>>
> 
> Is of_default_bus_match_table still accessed or can it be made static
> and the header file entry removed?

Thanks for your review.

There is still a user in drivers/memory/omap-gpmc.c, but it(OMAP_GPMC) only can
be selected by ARCH_OMAP2PLUS, keep of_default_bus_match_table in header file.

> 
> Thanks for cleaning up all the drivers, I just needed it for one driver.
> 
> Hauke
> 
> .
>