linux-kernel - Re: [PATCH 03/15] mips: use of_platform_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Jan 2016 09:00:36 -0700
From:	Joshua Henderson <joshua.henderson@...rochip.com>
To:	Kefeng Wang <wangkefeng.wang@...wei.com>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
CC:	Arnd Bergmann <arnd@...db.de>, Shawn Guo <shawnguo@...nel.org>,
	Russell King <linux@....linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	Rob Herring <robh+dt@...nel.org>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	<guohanjun@...wei.com>, Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH 03/15] mips: use of_platform_default_populate() to
 populate default bus

On 01/26/2016 09:27 PM, Kefeng Wang wrote:
> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
> 
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
>  arch/mips/ath79/setup.c           | 2 +-
>  arch/mips/jz4740/setup.c          | 2 +-
>  arch/mips/mti-sead3/sead3-setup.c | 2 +-
>  arch/mips/pic32/pic32mzda/init.c  | 3 +--
>  arch/mips/pistachio/init.c        | 2 +-
>  arch/mips/xilfpga/init.c          | 2 +-
>  6 files changed, 6 insertions(+), 7 deletions(-)
> 

[...]

> diff --git a/arch/mips/pic32/pic32mzda/init.c b/arch/mips/pic32/pic32mzda/init.c
> index 775ff90..77ecf32 100644
> --- a/arch/mips/pic32/pic32mzda/init.c
> +++ b/arch/mips/pic32/pic32mzda/init.c
> @@ -147,8 +147,7 @@ static int __init plat_of_setup(void)
>  		panic("Device tree not present");
>  
>  	pic32_of_prepare_platform_data(pic32_auxdata_lookup);
> -	if (of_platform_populate(NULL, of_default_bus_match_table,
> -				 pic32_auxdata_lookup, NULL))
> +	if (of_platform_default_populate(NULL, pic32_auxdata_lookup, NULL))
>  		panic("Failed to populate DT");
>  
>  	return 0;

I'll one-up just compile-testing for this.

Tested-by: Joshua Henderson <joshua.henderson@...rochip.com>

[...]