linux-kernel - RE: [PATCH v4 1/2] regulator: act8945a: add regulator driver for ACT8945A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B256D81BAE5131468A838E5D7A243641D63FBF8B@penmbx01>
Date:	Fri, 29 Jan 2016 01:20:08 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	Mark Brown <broonie@...nel.org>
CC:	Liam Girdwood <lgirdwood@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"Krzysztof Kozlowski" <k.kozlowski@...sung.com>,
	Javier Martinez Canillas <javier@...hile0.org>,
	Lee Jones <lee.jones@...aro.org>,
	Peter Korsgaard <jacmet@...il.com>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH v4 1/2] regulator: act8945a: add regulator driver for
 ACT8945A

Hi Mark,

> -----Original Message-----
> From: Mark Brown [mailto:broonie@...nel.org]
> Sent: 2016年1月29日 8:16
> To: Yang, Wenyou <Wenyou.Yang@...el.com>
> Cc: Liam Girdwood <lgirdwood@...il.com>; Rob Herring <robh+dt@...nel.org>;
> Pawel Moll <pawel.moll@....com>; Ian Campbell
> <ijc+devicetree@...lion.org.uk>; Kumar Gala <galak@...eaurora.org>;
> Krzysztof Kozlowski <k.kozlowski@...sung.com>; Javier Martinez Canillas
> <javier@...hile0.org>; Lee Jones <lee.jones@...aro.org>; Peter Korsgaard
> <jacmet@...il.com>; Ferre, Nicolas <Nicolas.FERRE@...el.com>; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> devicetree@...r.kernel.org
> Subject: Re: [PATCH v4 1/2] regulator: act8945a: add regulator driver for
> ACT8945A
> 
> On Wed, Jan 27, 2016 at 10:57:42AM +0800, Wenyou Yang wrote:
> 
> > +static const struct of_device_id act8945a_pmic_of_match[] = {
> > +	{ .compatible = "active-semi,act8945a-regulator" },
> > +	{ },
> > +};
> > +MODULE_DEVICE_TABLE(of, act8945a_pmic_of_match);
> 
> This seems mostly OK but why do we have a compatible string here - shouldn't
> the MFD be able to instantiate the regulator function without needing this?

Because I got feedback from Javier for the act8945a-charger patches of this MFD series,
He said missing the OF match table will cause the module autoloading broken. 

http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/398113.html

What do you think about it?


Best Regards,
Wenyou Yang