[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160129001603.GM4130@sirena.org.uk>
Date: Fri, 29 Jan 2016 01:16:03 +0100
From: Mark Brown <broonie@...nel.org>
To: Wenyou Yang <wenyou.yang@...el.com>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Krzysztof Kozlowski <k.kozlowski@...sung.com>,
Javier Martinez Canillas <javier@...hile0.org>,
Lee Jones <lee.jones@...aro.org>,
Peter Korsgaard <jacmet@...il.com>,
Nicolas Ferre <nicolas.ferre@...el.com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH v4 1/2] regulator: act8945a: add regulator driver for
ACT8945A
On Wed, Jan 27, 2016 at 10:57:42AM +0800, Wenyou Yang wrote:
> +static const struct of_device_id act8945a_pmic_of_match[] = {
> + { .compatible = "active-semi,act8945a-regulator" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, act8945a_pmic_of_match);
This seems mostly OK but why do we have a compatible string here -
shouldn't the MFD be able to instantiate the regulator function without
needing this?
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists