linux-kernel - Re: [PATCH 1/2] staging:iio:adc:added space around '-'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56ACD39A.1040003@metafoo.de>
Date:	Sat, 30 Jan 2016 16:15:38 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Joe Perches <joe@...ches.com>
Cc:	devel@...verdev.osuosl.org, Michael.Hennerich@...log.com,
	linux-iio@...r.kernel.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, pmeerw@...erw.net,
	Bhumika Goyal <bhumirks@...il.com>
Subject: Re: [PATCH 1/2] staging:iio:adc:added space around '-'

On 01/30/2016 04:12 PM, Dan Carpenter wrote:
> We could make checkpatch.pl not complain if the line says checkpatch: on
> it.  It would look like this.
> 
> -               in_voltage-voltage_thresh_low_value,
> +               in_voltage-voltage_thresh_low_value, /* checkpatch: not math */
> 
> I suppose I could have made the explanation longer since the it won't
> complain about the 80 character limit...  What do you guys think?

We could add it as a temporary way to silence the checker. But it feels a
bit ugly, there is really no reason why this shouldn't be a string, other
than that the current device attr macros don't support that.

- Lars