linux-kernel - Re: [PATCH 10/15] bus: imx-weim: use of_platform_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160201135507.GJ10671@tiger>
Date:	Mon, 1 Feb 2016 21:55:07 +0800
From:	Shawn Guo <shawnguo@...nel.org>
To:	Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Arnd Bergmann <arnd@...db.de>,
	Russell King <linux@....linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	Rob Herring <robh+dt@...nel.org>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	guohanjun@...wei.com,
	"Signed-off-by : Huang Shijie" <b32955@...escale.com>,
	Shawn Guo <shawn.guo@...aro.org>
Subject: Re: [PATCH 10/15] bus: imx-weim: use of_platform_default_populate()
 to populate default bus

On Wed, Jan 27, 2016 at 12:27:47PM +0800, Kefeng Wang wrote:
> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
> 
> Cc: Signed-off-by: Huang Shijie <b32955@...escale.com>
> Cc: Shawn Guo <shawn.guo@...aro.org>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>

Acked-by: Shawn Guo <shawn.guo@...aro.org>

> ---
>  drivers/bus/imx-weim.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index e98d15e..557a71c 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -163,9 +163,8 @@ static int __init weim_parse_dt(struct platform_device *pdev,
>  	}
>  
>  	if (have_child)
> -		ret = of_platform_populate(pdev->dev.of_node,
> -				   of_default_bus_match_table,
> -				   NULL, &pdev->dev);
> +		ret = of_platform_default_populate(pdev->dev.of_node,
> +						   NULL, &pdev->dev);
>  	if (ret)
>  		dev_err(&pdev->dev, "%s fail to create devices.\n",
>  			pdev->dev.of_node->full_name);
> -- 
> 2.6.0.GIT
> 
>