linux-kernel - Re: [PATCH v2 01/15] arm: use of_platform_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1694609.jjsREDbl4R@diego>
Date:	Mon, 01 Feb 2016 15:22:44 +0100
From:	Heiko Stübner <heiko@...ech.de>
To:	Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Arnd Bergmann <arnd@...db.de>, Shawn Guo <shawnguo@...nel.org>,
	Russell King <linux@....linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	Rob Herring <robh+dt@...nel.org>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	guohanjun@...wei.com, Nicolas Ferre <nicolas.ferre@...el.com>,
	Ray Jui <rjui@...adcom.com>, Lee Jones <lee@...nel.org>,
	Krzysztof Halasa <khalasa@...p.pl>,
	Kukjin Kim <kgene@...nel.org>, Rob Herring <robh@...nel.org>,
	Santosh Shilimkar <ssantosh@...nel.org>,
	Roland Stigge <stigge@...com.de>,
	Jason Cooper <jason@...edaemon.net>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Viresh Kumar <vireshk@...nel.org>,
	Shiraz Hashim <shiraz.linux.kernel@...il.com>,
	Tony Prisk <linux@...sktech.co.nz>
Subject: Re: [PATCH v2 01/15] arm: use of_platform_default_populate() to populate default bus

Am Mittwoch, 27. Januar 2016, 15:53:00 schrieb Kefeng Wang:
> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---


> diff --git a/arch/arm/mach-rockchip/rockchip.c
> b/arch/arm/mach-rockchip/rockchip.c index 3f07cc5..07ef8ef 100644
> --- a/arch/arm/mach-rockchip/rockchip.c
> +++ b/arch/arm/mach-rockchip/rockchip.c
> @@ -73,7 +73,7 @@ static void __init rockchip_timer_init(void)
>  static void __init rockchip_dt_init(void)
>  {
>  	rockchip_suspend_init();
> -	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> +	of_platform_default_populate(NULL, NULL, NULL);
>  	platform_device_register_simple("cpufreq-dt", 0, NULL, 0);
>  }

sounds sensible, so

Acked-by: Heiko Stuebner <heiko@...ech.de>