linux-kernel - RE: [PATCH] infiniband: cxgb4: use %pR format string for printing resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <025701d15d0f$e67ed760$b37c8620$@opengridcomputing.com>
Date:	Mon, 1 Feb 2016 10:45:04 -0600
From:	"Steve Wise" <swise@...ngridcomputing.com>
To:	"'Arnd Bergmann'" <arnd@...db.de>,
	"'Doug Ledford'" <dledford@...hat.com>,
	"'Sean Hefty'" <sean.hefty@...el.com>,
	"'Hal Rosenstock'" <hal.rosenstock@...il.com>
Cc:	"'Steve Wise'" <swise@...lsio.com>, <linux-rdma@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH] infiniband: cxgb4: use %pR format string for printing resources


> Subject: [PATCH] infiniband: cxgb4: use %pR format string for printing resources
> 
> The cxgb4 prints an MMIO resource using the "0x%x" and "%p" format
> strings on the length and start, respective, but that
> triggers a compiler warning when using a 64-bit resource_size_t
> on a 32-bit architecture:
> 
> drivers/infiniband/hw/cxgb4/device.c: In function 'c4iw_rdev_open':
> drivers/infiniband/hw/cxgb4/device.c:807:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>        (void *)pci_resource_start(rdev->lldi.pdev, 2),
> 
> This changes the format string to use %pR instead, which pretty-prints
> the resource, avoids the warning and is shorter.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> This is an old warning I see rarely on ARM randconfig builds.


Acked-by: Steve Wise <swise@...ngridcomputing.com>