linux-kernel - [PATCH 1/2] ACPI, APEI: Fix leaked resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1454352468-14371-2-git-send-email-johunt@akamai.com>
Date:	Mon,  1 Feb 2016 13:47:47 -0500
From:	Joshua Hunt <johunt@...mai.com>
To:	Huang Ying <ying.huang@...el.com>, linux-acpi@...r.kernel.org
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org,
	Joshua Hunt <johunt@...mai.com>
Subject: [PATCH 1/2] ACPI, APEI: Fix leaked resources

We leak the NVS and arch resources (if used), in apei_resources_request.
They are allocated to make sure we exclude them from the APEI resources,
but they are never freed at the end of the function. Free them now.

Signed-off-by: Josh Hunt <johunt@...mai.com>

diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c
index a2c8d7a..1ac449b 100644
--- a/drivers/acpi/apei/apei-base.c
+++ b/drivers/acpi/apei/apei-base.c
@@ -536,6 +536,11 @@ int apei_resources_request(struct apei_resources *resources,
 		goto err_unmap_ioport;
 	}
 
+	/* Cleanup unmerged resources */
+	if (arch_apei_filter_addr)
+		apei_resources_fini(&arch_res);
+	apei_resources_fini(&nvs_resources);
+
 	return 0;
 err_unmap_ioport:
 	list_for_each_entry(res, &resources->ioport, list) {
-- 
1.7.9.5