linux-kernel - Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains also

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160201201936.GC20817@kernel.org>
Date:	Mon, 1 Feb 2016 17:19:36 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains
 also

Em Thu, Jan 28, 2016 at 12:40:50AM +0900, Namhyung Kim escreveu:
> Currently --percent-limit option only works for hist entries.  However
> it'd be better to have same effect to callchains as well

Documentation needs updating? It says:

--percent-limit::
        Do not show entries which have an overhead under that percent.
        (Default: 0).

 
> Requested-by: Andi Kleen <andi@...stfloor.org>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/builtin-report.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 2bf537f190a0..72ed0b46d5a1 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -75,7 +75,10 @@ static int report__config(const char *var, const char *value, void *cb)
>  		return 0;
>  	}
>  	if (!strcmp(var, "report.percent-limit")) {
> -		rep->min_percent = strtof(value, NULL);
> +		double pcnt = strtof(value, NULL);
> +
> +		rep->min_percent = pcnt;
> +		callchain_param.min_percent = pcnt;
>  		return 0;
>  	}
>  	if (!strcmp(var, "report.children")) {
> @@ -633,8 +636,10 @@ parse_percent_limit(const struct option *opt, const char *str,
>  		    int unset __maybe_unused)
>  {
>  	struct report *rep = opt->value;
> +	double pcnt = strtof(str, NULL);
>  
> -	rep->min_percent = strtof(str, NULL);
> +	rep->min_percent = pcnt;
> +	callchain_param.min_percent = pcnt;
>  	return 0;
>  }
>  
> -- 
> 2.6.4