linux-kernel - Re: [PATCH 6/9] staging: ion: Set minimum carveout heap allocation order to PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56AFBEA6.20708@redhat.com>
Date:	Mon, 1 Feb 2016 12:23:02 -0800
From:	Laura Abbott <labbott@...hat.com>
To:	John Stultz <john.stultz@...aro.org>,
	lkml <linux-kernel@...r.kernel.org>
Cc:	Rajmal Menariya <rajmal.menariya@...eadtrum.com>,
	sprd-ind-kernel-group@...glegroups.com,
	sanjeev.yadav@...eadtrum.com, Colin Cross <ccross@...roid.com>,
	Android Kernel Team <kernel-team@...roid.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Sumit Semwal <sumit.semwal@...aro.org>
Subject: Re: [PATCH 6/9] staging: ion: Set minimum carveout heap allocation
 order to PAGE_SHIFT

On 01/29/2016 10:07 PM, John Stultz wrote:
> From: Rajmal Menariya <rajmal.menariya@...eadtrum.com>
>
> In carveout heap, change minimum allocation order from 12 to
> PAGE_SHIFT. After this change each bit in bitmap (genalloc -
> General purpose special memory pool) represents one page size
> memory.
>
> Cc: sprd-ind-kernel-group@...glegroups.com
> Cc: sanjeev.yadav@...eadtrum.com
> Cc: Colin Cross <ccross@...roid.com>
> Cc: Android Kernel Team <kernel-team@...roid.com>
> Cc: Greg KH <gregkh@...uxfoundation.org>
> Cc: Laura Abbott <labbott@...hat.com>
> Cc: Sumit Semwal <sumit.semwal@...aro.org>
> Signed-off-by: Rajmal Menariya <rajmal.menariya@...eadtrum.com>
> [jstultz: Reworked commit message]
> Signed-off-by: John Stultz <john.stultz@...aro.org>

Acked-by: Laura Abbott <labbott@...hat.com>

> ---
>   drivers/staging/android/ion/ion_carveout_heap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion/ion_carveout_heap.c
> index 9156d82..e702ce6 100644
> --- a/drivers/staging/android/ion/ion_carveout_heap.c
> +++ b/drivers/staging/android/ion/ion_carveout_heap.c
> @@ -167,7 +167,7 @@ struct ion_heap *ion_carveout_heap_create(struct ion_platform_heap *heap_data)
>   	if (!carveout_heap)
>   		return ERR_PTR(-ENOMEM);
>
> -	carveout_heap->pool = gen_pool_create(12, -1);
> +	carveout_heap->pool = gen_pool_create(PAGE_SHIFT, -1);
>   	if (!carveout_heap->pool) {
>   		kfree(carveout_heap);
>   		return ERR_PTR(-ENOMEM);
>