linux-kernel - Re: [PATCH] EDAC, mpc85xx: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2016 16:15:43 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Johannes Thumshirn <jthumshirn@...e.de>,
	Guenter Roeck <linux@...ck-us.net>,
	Johannes Thumshirn <morbidrsa@...il.com>,
	Doug Thompson <dougthompson@...ssion.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org
Subject: Re: [PATCH] EDAC, mpc85xx: fix build warning

On Tue, Feb 02, 2016 at 08:43:57PM +0530, Sudip Mukherjee wrote:
> another way might be:
> 
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index b7139c1..968c0c0 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -1244,7 +1244,9 @@ static struct platform_driver * const drivers[] = {
>  static int __init mpc85xx_mc_init(void)
>  {
>  	int res = 0;
> +#ifdef CONFIG_FSL_SOC_BOOKE
>  	u32 pvr = 0;
> +#endif

Nah, this is the ugliest of them all. We want less ifdeffery, not more.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.