[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 2 Feb 2016 20:49:34 +0530
From: Sudip Mukherjee <sudipm.mukherjee@...il.com>
To: Borislav Petkov <bp@...en8.de>
Cc: Johannes Thumshirn <jthumshirn@...e.de>,
Guenter Roeck <linux@...ck-us.net>,
Johannes Thumshirn <morbidrsa@...il.com>,
Doug Thompson <dougthompson@...ssion.com>,
Mauro Carvalho Chehab <mchehab@....samsung.com>,
linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org
Subject: Re: [PATCH] EDAC, mpc85xx: fix build warning
On Tue, Feb 02, 2016 at 04:15:43PM +0100, Borislav Petkov wrote:
> On Tue, Feb 02, 2016 at 08:43:57PM +0530, Sudip Mukherjee wrote:
> > another way might be:
> >
> > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> > index b7139c1..968c0c0 100644
> > --- a/drivers/edac/mpc85xx_edac.c
> > +++ b/drivers/edac/mpc85xx_edac.c
> > @@ -1244,7 +1244,9 @@ static struct platform_driver * const drivers[] = {
> > static int __init mpc85xx_mc_init(void)
> > {
> > int res = 0;
> > +#ifdef CONFIG_FSL_SOC_BOOKE
> > u32 pvr = 0;
> > +#endif
>
> Nah, this is the ugliest of them all. We want less ifdeffery, not more.
ok, i am resending with __maybe_unused
regards
sudip
Powered by blists - more mailing lists