linux-kernel - Re: [PATCH 6/7] gpio: sch311x: Use devm_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201602020813.I6iRbhhs%fengguang.wu@intel.com>
Date:	Tue, 2 Feb 2016 08:11:14 +0800
From:	kbuild test robot <lkp@...el.com>
To:	William Breathitt Gray <vilhelm.gray@...il.com>
Cc:	kbuild-all@...org, linus.walleij@...aro.org, gnurou@...il.com,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] gpio: sch311x: Use devm_request_region

Hi William,

[auto build test WARNING on gpio/for-next]
[cannot apply to v4.5-rc2 next-20160201]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Use-devm_request_region/20160202-080012
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: i386-randconfig-x009-02010231 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/gpio/gpio-sch311x.c: In function 'sch311x_gpio_remove':
>> drivers/gpio/gpio-sch311x.c:286:28: warning: unused variable 'pdata' [-Wunused-variable]
     struct sch311x_pdev_data *pdata = dev_get_platdata(&pdev->dev);
                               ^

vim +/pdata +286 drivers/gpio/gpio-sch311x.c

12262bef Bruno Randolf    2013-12-04  270  		}
12262bef Bruno Randolf    2013-12-04  271  		dev_info(&pdev->dev,
12262bef Bruno Randolf    2013-12-04  272  			 "SMSC SCH311x GPIO block %d registered.\n", i);
12262bef Bruno Randolf    2013-12-04  273  	}
12262bef Bruno Randolf    2013-12-04  274  
12262bef Bruno Randolf    2013-12-04  275  	return 0;
12262bef Bruno Randolf    2013-12-04  276  
12262bef Bruno Randolf    2013-12-04  277  exit_err:
12262bef Bruno Randolf    2013-12-04  278  	/* release already registered chips */
12262bef Bruno Randolf    2013-12-04  279  	for (--i; i >= 0; i--)
12262bef Bruno Randolf    2013-12-04  280  		gpiochip_remove(&priv->blocks[i].chip);
12262bef Bruno Randolf    2013-12-04  281  	return err;
12262bef Bruno Randolf    2013-12-04  282  }
12262bef Bruno Randolf    2013-12-04  283  
12262bef Bruno Randolf    2013-12-04  284  static int sch311x_gpio_remove(struct platform_device *pdev)
12262bef Bruno Randolf    2013-12-04  285  {
ab128afc Nizam Haider     2015-11-23 @286  	struct sch311x_pdev_data *pdata = dev_get_platdata(&pdev->dev);
12262bef Bruno Randolf    2013-12-04  287  	struct sch311x_gpio_priv *priv = platform_get_drvdata(pdev);
9f5132ae abdoulaye berthe 2014-07-12  288  	int i;
12262bef Bruno Randolf    2013-12-04  289  
12262bef Bruno Randolf    2013-12-04  290  	for (i = 0; i < ARRAY_SIZE(priv->blocks); i++) {
9f5132ae abdoulaye berthe 2014-07-12  291  		gpiochip_remove(&priv->blocks[i].chip);
12262bef Bruno Randolf    2013-12-04  292  		dev_info(&pdev->dev,
12262bef Bruno Randolf    2013-12-04  293  			 "SMSC SCH311x GPIO block %d unregistered.\n", i);
12262bef Bruno Randolf    2013-12-04  294  	}

:::::: The code at line 286 was first introduced by commit
:::::: ab128afce4ea8a496fc42553215f6635a14f05c3 gpio: use dev_get_platdata()

:::::: TO: Nizam Haider <nizamhaider786@...il.com>
:::::: CC: Linus Walleij <linus.walleij@...aro.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (27134 bytes)