linux-kernel - Re: [PATCH 0/7] Use devm_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVeFu+3u7aDfDHSkQ84JE_Av9hHGR0y4RRmEOi6s9XVtqMUhA@mail.gmail.com>
Date:	Wed, 3 Feb 2016 09:26:13 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	William Breathitt Gray <vilhelm.gray@...il.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/7] Use devm_request_region

On Tue, Feb 2, 2016 at 8:54 AM, William Breathitt Gray
<vilhelm.gray@...il.com> wrote:
> By the time request_region is called in several GPIO drivers, a
> corresponding device structure has already been allocated. The
> devm_request_region function should be used to help simplify the cleanup
> code and reduce the possible points of failure.
>
> William Breathitt Gray (7):
>   gpio: 104-dio-48e: Use devm_request_region
>   gpio: 104-idi-48: Use devm_request_region
>   gpio: 104-idio-16: Use devm_request_region
>   gpio: amd8111: Use devm_request_region
>   gpio: ich: Use devm_request_region
>   gpio: sch311x: Use devm_request_region
>   gpio: ws16c48: Use devm_request_region
>
>  drivers/gpio/gpio-104-dio-48e.c | 22 +++++++-----------
>  drivers/gpio/gpio-104-idi-48.c  | 22 +++++++-----------
>  drivers/gpio/gpio-104-idio-16.c | 22 +++++++-----------
>  drivers/gpio/gpio-amd8111.c     |  7 +++---
>  drivers/gpio/gpio-ich.c         | 51 ++++++++---------------------------------
>  drivers/gpio/gpio-sch311x.c     |  7 +++---
>  drivers/gpio/gpio-ws16c48.c     | 22 +++++++-----------
>  7 files changed, 47 insertions(+), 106 deletions(-)

Did a quick review and this looks all good, modulo the compile warning
on patch 6.

Reviewed-by: Alexandre Courbot <acourbot@...dia.com>