linux-kernel - Re: [PATCH 0/7] Use devm_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2016 19:46:34 -0500
From:	William Breathitt Gray <vilhelm.gray@...il.com>
To:	Alexandre Courbot <gnurou@...il.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/7] Use devm_request_region

On 02/02/2016 07:26 PM, Alexandre Courbot wrote:
> On Tue, Feb 2, 2016 at 8:54 AM, William Breathitt Gray
> <vilhelm.gray@...il.com> wrote:
>> By the time request_region is called in several GPIO drivers, a
>> corresponding device structure has already been allocated. The
>> devm_request_region function should be used to help simplify the cleanup
>> code and reduce the possible points of failure.
>>
>> William Breathitt Gray (7):
>>   gpio: 104-dio-48e: Use devm_request_region
>>   gpio: 104-idi-48: Use devm_request_region
>>   gpio: 104-idio-16: Use devm_request_region
>>   gpio: amd8111: Use devm_request_region
>>   gpio: ich: Use devm_request_region
>>   gpio: sch311x: Use devm_request_region
>>   gpio: ws16c48: Use devm_request_region
>>
>>  drivers/gpio/gpio-104-dio-48e.c | 22 +++++++-----------
>>  drivers/gpio/gpio-104-idi-48.c  | 22 +++++++-----------
>>  drivers/gpio/gpio-104-idio-16.c | 22 +++++++-----------
>>  drivers/gpio/gpio-amd8111.c     |  7 +++---
>>  drivers/gpio/gpio-ich.c         | 51 ++++++++---------------------------------
>>  drivers/gpio/gpio-sch311x.c     |  7 +++---
>>  drivers/gpio/gpio-ws16c48.c     | 22 +++++++-----------
>>  7 files changed, 47 insertions(+), 106 deletions(-)
> 
> Did a quick review and this looks all good, modulo the compile warning
> on patch 6.
> 
> Reviewed-by: Alexandre Courbot <acourbot@...dia.com>

The compile warning for patch 6 appears to be benign and preexisting: an 
unused variable. Since the warning is unrelated to this patchset, I'll   
submit a separate patch to remove the unused variable so that this        
warning will no longer show up on later compiles.                        
                                                                         
William Breathitt Gray