linux-kernel - Re: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 04 Feb 2016 00:41:39 +0100
From:	Olivier Blin <dev@...no.org>
To:	Lubomir Rintel <lkundrak@...sk>
Cc:	linux-rpi-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	Peter Chen <peter.chen@...escale.com>
Subject: Re: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree

Lubomir Rintel <lkundrak@...sk> writes:

> diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
> index ef54050..32bbd2a 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
> +++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts

Hi,

Shouldn't this be common to all RPi1 B and RPi2 models, instead of being
specific to just RPi B+?

> +&usb {
> +	usb1@01 {
> +		compatible = "usb1d6b,0002";
> +		reg = <01>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethernet: usbether@01 {
> +			compatible = "usb0424,9514";
> +			reg = <01>;
> +		};
> +	};
> +};

For reference, on RPi2:
Bus 001 Device 003: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter
Bus 001 Device 002: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

Thanks

-- 
Olivier Blin - blino