linux-kernel - RE: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HE1PR04MB14503FBA55F4F9C19EE669B68BD10@HE1PR04MB1450.eurprd04.prod.outlook.com>
Date:	Thu, 4 Feb 2016 06:28:38 +0000
From:	Peter Chen <peter.chen@....com>
To:	Olivier Blin <dev@...no.org>, Lubomir Rintel <lkundrak@...sk>
CC:	"linux-rpi-kernel@...ts.infradead.org" 
	<linux-rpi-kernel@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Peter Chen <peter.chen@...escale.com>
Subject: RE: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree

 
> Lubomir Rintel <lkundrak@...sk> writes:
> 
> > diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
> > b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
> > index ef54050..32bbd2a 100644
> > --- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
> > +++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
> 
> Hi,
> 
> Shouldn't this be common to all RPi1 B and RPi2 models, instead of being
> specific to just RPi B+?
> 
> > +&usb {
> > +	usb1@01 {
> > +		compatible = "usb1d6b,0002";
> > +		reg = <01>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		ethernet: usbether@01 {
> > +			compatible = "usb0424,9514";
> > +			reg = <01>;
> > +		};
> > +	};
> > +};
> 
> For reference, on RPi2:

Using "lsusb -t" you may get bus topology.

> Bus 001 Device 003: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter

It is the ethernet device, you may need to change vid/pid in dts. 

> Bus 001 Device 002: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub

It is the hub device, you may need to change vid/pid in dts.

> Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> 
 
It is root hub, it doesn't need to be described at dts.

Best regards,
Peter