linux-kernel - Re: + x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160203074835.GB32652@gmail.com>
Date:	Wed, 3 Feb 2016 08:48:35 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	akpm@...ux-foundation.org
Cc:	hpa@...or.com, mingo@...e.hu, tglx@...utronix.de,
	willy@...ux.intel.com, mm-commits@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: +
 x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes.patch
 added to -mm tree


* akpm@...ux-foundation.org <akpm@...ux-foundation.org> wrote:

> diff -puN arch/x86/include/asm/pgtable_64.h~x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes arch/x86/include/asm/pgtable_64.h
> --- a/arch/x86/include/asm/pgtable_64.h~x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes
> +++ a/arch/x86/include/asm/pgtable_64.h
> @@ -111,8 +111,10 @@ static inline pud_t native_pudp_get_and_
>  #ifdef CONFIG_SMP
>  	return native_make_pud(xchg(&pudp->pud, 0));
>  #else
> -	/* native_local_pudp_get_and_clear,
> -	   but duplicated because of cyclic dependency */
> +	/*
> +	 * native_local_pudp_get_and_clear, but duplicated because of cyclic
> +	 * dependency
> +	 */
>  	pud_t ret = *pudp;
>  	native_pud_clear(pudp);
>  	return ret;

When referring to functions in comments (or changelogs) please use () to make it 
clear on sight what is being referred to.

Also, please try to construct proper English sentences with verbs and such!

I.e. something like this would work for me:

> +	/*
> +	 * This is a duplicate of native_local_pudp_get_and_clear(),
> +	 * because we cannot use the original due to a cyclic header
> +	 * file dependency:
> +	 */

(Assuming I managed to decode the shorthand form properly.)

Thanks,

	Ingo