linux-kernel - Re: + x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Mar 2016 15:30:18 -0500
From:	Matthew Wilcox <willy@...ux.intel.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	akpm@...ux-foundation.org, hpa@...or.com, mingo@...e.hu,
	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	Andrea Arcangeli <aarcange@...hat.com>
Subject: Re: +
 x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes.patch
 added to -mm tree

On Wed, Feb 03, 2016 at 08:48:35AM +0100, Ingo Molnar wrote:
> > @@ -111,8 +111,10 @@ static inline pud_t native_pudp_get_and_
> >  #ifdef CONFIG_SMP
> >  	return native_make_pud(xchg(&pudp->pud, 0));
> >  #else
> > -	/* native_local_pudp_get_and_clear,
> > -	   but duplicated because of cyclic dependency */
> > +	/*
> > +	 * native_local_pudp_get_and_clear, but duplicated because of cyclic
> > +	 * dependency
> > +	 */
> >  	pud_t ret = *pudp;
> >  	native_pud_clear(pudp);
> >  	return ret;
> 
> When referring to functions in comments (or changelogs) please use () to make it 
> clear on sight what is being referred to.
> 
> Also, please try to construct proper English sentences with verbs and such!
> 
> I.e. something like this would work for me:
> 
> > +	/*
> > +	 * This is a duplicate of native_local_pudp_get_and_clear(),
> > +	 * because we cannot use the original due to a cyclic header
> > +	 * file dependency:
> > +	 */
> 
> (Assuming I managed to decode the shorthand form properly.)

I have no idea what it means.  This is copy-and-change of the pmd version,
which was originally commit db3eb96f4e6281b84dd33c8980dacc27f2efe177 by
Andrea.

It seems unfair to ask me to do better than what is there right now.