linux-kernel - Re: [PATCH] HID: Check whether if the hidraw is NULL pointer before release.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1602051431380.22727@cbobk.fhfr.pm>
Date:	Fri, 5 Feb 2016 14:33:22 +0100 (CET)
From:	Jiri Kosina <jikos@...nel.org>
To:	shenpengru@...il.com
cc:	benjamin.tissoires@...hat.com, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, shenpengru <shenpengru@...omi.com>
Subject: Re: [PATCH] HID: Check whether if the hidraw is NULL pointer before
 release.

On Tue, 2 Feb 2016, shenpengru@...il.com wrote:

> From: shenpengru <shenpengru@...omi.com>
> 
> The logic of service which operate hidraw device in user-space may
> not correct, sometimes it may release hidraw dev for more than once.
> In order to prevent this situation, we need to make the driver more
> robust.

Hmm .. how would you call close(fd) twice on the same descriptor and let 
it pass fput()?

I'd like to better understand how we ended up in this situation. Could you 
please provide more details?

Thanks a lot,

-- 
Jiri Kosina
SUSE Labs