linux-kernel - Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1454684126.2779.2.camel@v3.sk>
Date:	Fri, 05 Feb 2016 15:55:26 +0100
From:	Lubomir Rintel <lkundrak@...sk>
To:	Olivier Blin <dev@...no.org>
Cc:	linux-rpi-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	Peter Chen <peter.chen@...escale.com>,
	Stephen Warren <swarren@...dotorg.org>,
	popcornmix <popcornmix@...il.com>
Subject: Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device
 trees

Hi Olivier,

On Fri, 2016-02-05 at 15:25 +0100, Olivier Blin wrote:
> Lubomir Rintel <lkundrak@...sk> writes:
> 
> > diff --git a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> > b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> [...]
> > @@ -33,3 +37,17 @@
> >  		brcm,function = <BCM2835_FSEL_ALT0>;
> >  	};
> >  };
> > +
> > +&usb {
> > +	usb1@1 {
> > +		compatible = "usb0424,9514";
> > +		reg = <01>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		ethernet: usbether@1 {
> > +			compatible = "usb0424,ec00";
> > +			reg = <01>;
> > +		};
> > +	};
> > +};
> 
> Hi,
> 
> This works for me, after making sure that your u-boot patch gets a
> chance to be run (unset usbethaddr from u-boot).

Thanks for that.

> Though, I am not really DT-literate, but shouldn't the ethernet block
> use the PID from the ethernet device?
> The usbether device is 9514 on RPi2, while ec00 is the hub.

Are you sure? I didn't check on RPi2, but I check the Models B and B+
and the ethernet device was 0xec00 on both. The driver attaches to that
product ID:

[lkundrak@...arok linux]$ modinfo smsc95xx |grep EC
alias:          usb:v0424pEC00d*dc*dsc*dp*ic*isc*ip*in*
[lkundrak@...arok linux]$ modinfo smsc95xx |grep 9514
[lkundrak@...arok linux]$

> Your patch works, but this works as well after swapping the PIDs.
> 
> Thanks

Take care
Lubo