linux-kernel - Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1x7fijgnd9.fsf@unicorn.mansr.com>
Date:	Fri, 05 Feb 2016 15:58:42 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Sebastian Frias <sf84@...oste.net>,
	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, mason <slash.tmp@...e.fr>
Subject: Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver

Andy Shevchenko <andy.shevchenko@...il.com> writes:

> On Fri, Feb 5, 2016 at 3:39 PM, Måns Rullgård <mans@...sr.com> wrote:
>>> +                     if (ret < 0) {
>>> +                             dev_err(&pdev->dev, "broken fixed-link specification\n");
>>
>> Line is longer than 80 chars.
>
> This is actually okay, though I would recommend to move long string
> literal to the next line.

I only mentioned it because fixing it was trivial.

-- 
Måns Rullgård