linux-kernel - Re: [PATCH] ASoC: mxs-saif: check BUSY bit in hw_params() only if not mclk_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160205160022.GX4455@sirena.org.uk>
Date:	Fri, 5 Feb 2016 16:00:22 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Måns Rullgård <mans@...sr.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: mxs-saif: check BUSY bit in hw_params() only if
 not mclk_in_use

On Fri, Feb 05, 2016 at 01:43:22PM +0000, Måns Rullgård wrote:
> Mark Brown <broonie@...nel.org> writes:

> > By looking at people working on the driver in git and the authors listed
> > in the driver (get_maintainer --git will do most of this for you, though
> > you do have to think about false positives).  As previously advised this
> > is not something that can be fully automated, you need to think about
> > who you are sending things to and why.

> Most files have been touched by many people.  I thought the entire point
> of the MAINTAINERS file was to remove the guesswork from choosing where
> to send patches.  Apparently sound/ has rules of its own.

No, this is true in general for the kernel - I'm just repeating
SubmittingPatches to you here.  Most individual drivers don't have a
specific entry in MAINTAINERS and it's probably not worth the bother
trying to get it completely 100% accurate.  MAINTAINERS is there to be
helpful and to have things like lists and git hanging off it but it's
not the be all and end all of everything, it still generates false
positives (consider how many ASoC patches Jaroslav has reviewed for
example) and false negatives.  No automated system is going to be
perfect, at some point you're going to need to think.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)