linux-kernel - Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160207173314.GQ3056@var.home>
Date:	Sun, 7 Feb 2016 18:33:14 +0100
From:	Samuel Thibault <samuel.thibault@...-lyon.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	William Hubbs <w.d.hubbs@...il.com>,
	Chris Brannon <chris@...-brannons.com>,
	Kirk Reiser <kirk@...sers.ca>,
	Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	speakup@...ux-speakup.org,
	driverdevel <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300

Geert Uytterhoeven, on Sun 07 Feb 2016 10:18:46 +0100, wrote:
> On Mon, Feb 1, 2016 at 9:06 AM, Samuel Thibault
> <samuel.thibault@...-lyon.org> wrote:
> > mn10300 uses an mmio-driven uart. This is not supported by speakup, so
> > prevent from enabling it.
> 
> Just wondering, what are the symptoms of the failure?

It'll try to request the 0x00-0x08 ports and fail, returning -ENODEV.

> Is it a compile-time or run-time failure?

The fix is for compile-time. run-time failure will already return
-ENODEV.

> Is this about drivers/staging/speakup/serialio.c?

Yes.

This code is to be replaced anyway.

Samuel