linux-kernel - Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXKj+KPhgMwihQbog8migVSwuycT8WRFQj5AkY1Or-Oqg@mail.gmail.com>
Date:	Sun, 7 Feb 2016 10:18:46 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Samuel Thibault <samuel.thibault@...-lyon.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	William Hubbs <w.d.hubbs@...il.com>,
	Chris Brannon <chris@...-brannons.com>,
	Kirk Reiser <kirk@...sers.ca>,
	Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	speakup@...ux-speakup.org,
	driverdevel <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300

Hi Samuel,

On Mon, Feb 1, 2016 at 9:06 AM, Samuel Thibault
<samuel.thibault@...-lyon.org> wrote:
> mn10300 uses an mmio-driven uart. This is not supported by speakup, so
> prevent from enabling it.

Just wondering, what are the symptoms of the failure?
Is it a compile-time or run-time failure?

Is this about drivers/staging/speakup/serialio.c?
I guess there are many other platforms where the UART is MMIO-driven...

> Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>
>
> --- a/drivers/staging/speakup/Kconfig
> +++ b/drivers/staging/speakup/Kconfig
> @@ -1,7 +1,7 @@
>  menu "Speakup console speech"
>
>  config SPEAKUP
> -       depends on VT
> +       depends on VT && !MN10300
>         tristate "Speakup core"
>         ---help---
>                 This is the Speakup screen reader.  Think of it as a

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds