linux-kernel - Re: [PATCH 2/2] mm: memcontrol: drop unnecessary lru locking from mem_cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28CC6A8F-E642-4DF5-A8E5-DB9BB62DA429@fb.com>
Date:	Sun, 7 Feb 2016 18:57:49 +0000
From:	Johannes Weiner <jweiner@...com>
To:	Vladimir Davydov <vdavydov@...tuozzo.com>
CC:	Johannes Weiner <hannes@...xchg.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hughd@...gle.com>, Michal Hocko <mhocko@...e.cz>,
	Mateusz Guzik <mguzik@...hat.com>,
	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH 2/2] mm: memcontrol: drop unnecessary lru locking from
 mem_cgroup_migrate()

> On Feb 7, 2016, at 1:41 PM, Vladimir Davydov <vdavydov@...tuozzo.com> wrote:
> 
>> On Thu, Feb 04, 2016 at 03:07:47PM -0500, Johannes Weiner wrote:
>> Migration accounting in the memory controller used to have to handle
>> both oldpage and newpage being on the LRU already; fuse's page cache
>> replacement used to pass a recycled newpage that had been uncharged
>> but not freed and removed from the LRU, and the memcg migration code
>> used to uncharge oldpage to "pass on" the existing charge to newpage.
>> 
>> Nowadays, pages are no longer uncharged when truncated from the page
>> cache, but rather only at free time, so if a LRU page is recycled in
>> page cache replacement it'll also still be charged. And we bail out of
>> the charge transfer altogether in that case. Tell commit_charge() that
>> we know newpage is not on the LRU, to avoid taking the zone->lru_lock
>> unnecessarily from the migration path.
>> 
>> But also, oldpage is no longer uncharged inside migration. We only use
>> oldpage for its page->mem_cgroup and page size, so we don't care about
>> its LRU state anymore either. Remove any mention from the kernel doc.
>> 
>> Signed-off-by: Johannes Weiner <hannes@...xchg.org>
>> Suggested-by: Hugh Dickins <hughd@...gle.com>
> 
> Acked-by: Vladimir Davydov <vdavydov@...tuozzo.com>

Thanks!

> @@ -5483,6 +5483,7 @@ void mem_cgroup_migrate(struct page *oldpage, struct page *newpage)
>    unsigned int nr_pages;
>    bool compound;
> 
> +    VM_BUG_ON_PAGE(PageLRU(newpage), newpage);

That's actually possible for fuse. But in that case newpage is charged and we bail.