linux-kernel - Re: [PATCH] link up validation moved to pcie-designware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 08 Feb 2016 17:40:30 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Joao Pinto <Joao.Pinto@...opsys.com>
Cc:	helgaas@...nel.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, CARLOS.PALMINHA@...opsys.com
Subject: Re: [PATCH] link up validation moved to pcie-designware

On Monday 08 February 2016 12:43:58 Joao Pinto wrote:
> This patch goal is to centralize in pcie-designware the link up
> validation. A new function was added to pci-designware that is
> responsible for doing such a task. This was implemented in a form that
> permits flexibility for all SoCs.
> 
> Signed-off-by: Joao Pinto <jpinto@...opsys.com>

I believe the different timeouts in each driver are just coincidence
and partly based on who reviewed which driver.

I'm pretty sure it doesn't really matter at all, and we can just use
the same loop for every one.

I was also hoping that a little more than just the loop could be
unified between the various establish_link() functions. I have a
feeling that each one just implements a subset of what is actually
required, so they are buggy in different ways because nobody
has the datasheet.

	Arnd