linux-kernel - Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Feb 2016 16:51:29 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Mark Brown <broonie@...nel.org>
CC:	Thomas Gleixner <tglx@...utronix.de>, <lee.jones@...aro.org>,
	<alexandre.belloni@...e-electrons.com>, <k.kozlowski@...sung.com>,
	<javier@....samsung.com>, <gregkh@...uxfoundation.org>,
	<a.zummo@...ertech.it>, <cw00.choi@...sung.com>,
	<linux-kernel@...r.kernel.org>, <rtc-linux@...glegroups.com>
Subject: Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq


On Tuesday 09 February 2016 04:57 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Feb 09, 2016 at 02:38:28PM +0530, Laxman Dewangan wrote:
>> On Tuesday 09 February 2016 10:46 AM, Laxman Dewangan wrote:
>>> Do we need to dispose all virtual irq in regmap_del_irq_chip() before
>>> actually removing domain?
>>> This means we need to store the created virq  in regmap_irq_chip_data for
>>> disposing it when removing the irq domain.
>> It is easy for me to communicate through code to avoid any confusion. So do
>> you want to say as follows? In this case, there is no need of any new API.
> Something like that, yes.  Documentation/SubmittingPatches please...
Thanks for suggestion and review.

Sure, I will do this.

BTW, I like to add devm_ version of regmap_add_irq_chip() and 
regmap_del_irq_chip() so that error path and .remove callback is much 
cleaner. If you are fine then I can make part of this series so that rtc 
driver will look more simple on probe/remove callback.