linux-kernel - Re: [PATCH v11 4/4] Watchdog: introduce ARM SBSA watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56BA244E.1020402@codeaurora.org>
Date:	Tue, 9 Feb 2016 11:39:26 -0600
From:	Timur Tabi <timur@...eaurora.org>
To:	fu.wei@...aro.org, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, wim@...ana.be, linux@...ck-us.net,
	corbet@....net, catalin.marinas@....com, will.deacon@....com,
	Suravee.Suthikulpanit@....com
Cc:	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
	linux-doc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linaro-acpi@...ts.linaro.org,
	rruigrok@...eaurora.org, harba@...eaurora.org, cov@...eaurora.org,
	dyoung@...hat.com, panand@...hat.com, graeme.gregory@...aro.org,
	al.stone@...aro.org, hanjun.guo@...aro.org, jcm@...hat.com,
	arnd@...db.de, leo.duran@....com, sudeep.holla@....com
Subject: Re: [PATCH v11 4/4] Watchdog: introduce ARM SBSA watchdog driver

fu.wei@...aro.org wrote:

> +		if (!action)
> +			dev_warn(dev, "fall back to signle stage mode.\n");

"falling back to single stage mode"

Acked-by: Timur Tabi <timur@...eaurora.org>

The whole "calculate the timeouts different if 'action' is enabled" 
seems clunky to me, but I can't think of a better way to handle it.

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.