linux-kernel - Re: [PATCH V4 6/6] cpufreq: governor: Create and traverse list of policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160210051605.GO22111@vireshk>
Date:	Wed, 10 Feb 2016 10:46:05 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	juri.lelli@....com, linaro-kernel@...ts.linaro.org,
	linux-pm@...r.kernel.org, skannan@...eaurora.org,
	peterz@...radead.org, mturquette@...libre.com,
	steve.muckle@...aro.org, vincent.guittot@...aro.org,
	morten.rasmussen@....com, dietmar.eggemann@....com,
	shilpa.bhat@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 6/6] cpufreq: governor: Create and traverse list of
 policy_dbs to fix lockdep

On 09-02-16, 21:23, Rafael J. Wysocki wrote:
> > +	count = dbs_data->usage_count--;
> 
> This appears to be planting a bug.
> 
> The way you wrote it the decrementation will take place after the assignment, so
> count will contain the old value.

Oh crap, what was I smoking :)

-- 
viresh