linux-kernel - Re: [PATCH v6 4/7] clk: mediatek: Add MT2701 clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160210200853.26445.15165@quark.deferred.io>
Date:	Wed, 10 Feb 2016 12:08:53 -0800
From:	Michael Turquette <mturquette@...libre.com>
To:	James Liao <jamesjj.liao@...iatek.com>,
	"Matthias Brugger" <matthias.bgg@...il.com>,
	"Stephen Boyd" <sboyd@...eaurora.org>,
	"Rob Herring" <robh@...nel.org>
Cc:	"John Crispin" <blogic@...nwrt.org>,
	"Arnd Bergmann" <arnd@...db.de>,
	"Sascha Hauer" <kernel@...gutronix.de>,
	"Daniel Kurtz" <djkurtz@...omium.org>,
	"Philipp Zabel" <p.zabel@...gutronix.de>,
	srv_heupstream@...iatek.com, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-mediatek@...ts.infradead.org, linux-clk@...r.kernel.org,
	"Shunli Wang" <shunli.wang@...iatek.com>,
	"James Liao" <jamesjj.liao@...iatek.com>
Subject: Re: [PATCH v6 4/7] clk: mediatek: Add MT2701 clock support

Quoting James Liao (2016-02-05 01:37:27)
> +CLK_OF_DECLARE(mtk_topckgen, "mediatek,mt2701-topckgen", mtk_topckgen_init);
> +CLK_OF_DECLARE(mtk_infrasys, "mediatek,mt2701-infracfg", mtk_infrasys_init);
> +CLK_OF_DECLARE(mtk_pericfg, "mediatek,mt2701-pericfg", mtk_pericfg_init);
> +CLK_OF_DECLARE(mtk_mmsys, "mediatek,mt2701-mmsys", mtk_mmsys_init);
> +CLK_OF_DECLARE(mtk_imgsys, "mediatek,mt2701-imgsys", mtk_imgsys_init);
> +CLK_OF_DECLARE(mtk_vdecsys, "mediatek,mt2701-vdecsys", mtk_vdecsys_init);
> +CLK_OF_DECLARE(mtk_hifsys, "mediatek,mt2701-hifsys", mtk_hifsys_init);
> +CLK_OF_DECLARE(mtk_ethsys, "mediatek,mt2701-ethsys", mtk_ethsys_init);
> +CLK_OF_DECLARE(mtk_bdpsys, "mediatek,mt2701-bdpsys", mtk_bdpsys_init);
> +CLK_OF_DECLARE(mtk_apmixedsys, "mediatek,mt2701-apmixedsys",

:-/

This is way too much CLK_OF_DECLARE and not enough Linux Driver Model.

I understand that some platforms really must initialize some clocks very
early, but can we please separate those into one table and call
CLK_OF_DECLARE on only that set, and then register the rest through a
platform_driver later on?

Best regards,
Mike