linux-kernel - Re: [PATCH v6 7/7] clk: mediatek: Enable critical clocks for MT2701

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160211213542.26445.82983@quark.deferred.io>
Date:	Thu, 11 Feb 2016 13:35:42 -0800
From:	Michael Turquette <mturquette@...libre.com>
To:	James Liao <jamesjj.liao@...iatek.com>,
	"Matthias Brugger" <matthias.bgg@...il.com>,
	"Stephen Boyd" <sboyd@...eaurora.org>,
	"Rob Herring" <robh@...nel.org>
Cc:	"John Crispin" <blogic@...nwrt.org>,
	"Arnd Bergmann" <arnd@...db.de>,
	"Sascha Hauer" <kernel@...gutronix.de>,
	"Daniel Kurtz" <djkurtz@...omium.org>,
	"Philipp Zabel" <p.zabel@...gutronix.de>,
	srv_heupstream@...iatek.com, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-mediatek@...ts.infradead.org, linux-clk@...r.kernel.org,
	"James Liao" <jamesjj.liao@...iatek.com>
Subject: Re: [PATCH v6 7/7] clk: mediatek: Enable critical clocks for MT2701

Hi James,

Quoting James Liao (2016-02-05 01:37:30)
> Some system clocks should be turned on by default on MT2701.
> This patch enable these clocks when related clocks have
> been registered.
> 
> Signed-off-by: James Liao <jamesjj.liao@...iatek.com>
> ---
>  drivers/clk/mediatek/clk-mt2701.c | 23 +++++++++++++++++++++--
>  1 file changed, 21 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/mediatek/clk-mt2701.c b/drivers/clk/mediatek/clk-mt2701.c
> index 01722e0..f7b4d52 100644
> --- a/drivers/clk/mediatek/clk-mt2701.c
> +++ b/drivers/clk/mediatek/clk-mt2701.c
> @@ -573,6 +573,21 @@ static const struct mtk_gate top_clks[] __initconst = {
>         GATE_TOP_AUD(CLK_TOP_AUD_I2S6_MCLK, "aud_i2s6_mclk", "aud_k6_src_div", 28),
>  };
>  
> +static struct clk_onecell_data *top_clk_data __initdata;
> +static struct clk_onecell_data *pll_clk_data __initdata;
> +
> +static void __init mtk_clk_enable_critical(void)
> +{
> +       if (!top_clk_data || !pll_clk_data)
> +               return;
> +
> +       clk_prepare_enable(pll_clk_data->clks[CLK_APMIXED_ARMPLL]);
> +       clk_prepare_enable(top_clk_data->clks[CLK_TOP_AXI_SEL]);
> +       clk_prepare_enable(top_clk_data->clks[CLK_TOP_MEM_SEL]);
> +       clk_prepare_enable(top_clk_data->clks[CLK_TOP_DDRPHYCFG_SEL]);
> +       clk_prepare_enable(top_clk_data->clks[CLK_TOP_RTC_SEL]);
> +}

I think we're close to having a better solution. Please see this patch
series[0] and let me know if it provides a better way for you to enable
these critical clocks instead of the open-coded solution.

[0] http://lkml.kernel.org/r/<1455225554-13267-1-git-send-email-mturquette@...libre.com>

Regards,
Mike

> +
>  static void __init mtk_topckgen_init(struct device_node *node)
>  {
>         struct clk_onecell_data *clk_data;
> @@ -585,7 +600,7 @@ static void __init mtk_topckgen_init(struct device_node *node)
>                 return;
>         }
>  
> -       clk_data = mtk_alloc_clk_data(CLK_TOP_NR);
> +       top_clk_data = clk_data = mtk_alloc_clk_data(CLK_TOP_NR);
>  
>         mtk_clk_register_fixed_clks(top_fixed_clks, ARRAY_SIZE(top_fixed_clks),
>                                                                 clk_data);
> @@ -606,6 +621,8 @@ static void __init mtk_topckgen_init(struct device_node *node)
>         if (r)
>                 pr_err("%s(): could not register clock provider: %d\n",
>                         __func__, r);
> +
> +       mtk_clk_enable_critical();

So you call the function here, and ...
>  }
>  CLK_OF_DECLARE(mtk_topckgen, "mediatek,mt2701-topckgen", mtk_topckgen_init);
>  
> @@ -1201,7 +1218,7 @@ static void __init mtk_apmixedsys_init(struct device_node *node)
>         struct clk_onecell_data *clk_data;
>         int r;
>  
> -       clk_data = mtk_alloc_clk_data(ARRAY_SIZE(apmixed_plls));
> +       pll_clk_data = clk_data = mtk_alloc_clk_data(ARRAY_SIZE(apmixed_plls));
>         if (!clk_data)
>                 return;
>  
> @@ -1212,6 +1229,8 @@ static void __init mtk_apmixedsys_init(struct device_node *node)
>         if (r)
>                 pr_err("%s(): could not register clock provider: %d\n",
>                         __func__, r);
> +
> +       mtk_clk_enable_critical();

... here as well. So the prepare_count and enable_count will be 2? I'm
not sure that this makes sense. If you have different clocks that need
to be enabled at different times (due to the split registration scheme
that you employ in this driver) then why not pass an array of those
clocks into mtk_clk_enable_critical?

Anyways, like I mentioned above I think we're close to a solution to
handle this in the framework.

One question: do you ever want these critical clocks to be gated by a
driver, or do you want them always on, forever?

Regards,
Mike

>  }
>  CLK_OF_DECLARE(mtk_apmixedsys, "mediatek,mt2701-apmixedsys",
>                                                         mtk_apmixedsys_init);
> -- 
> 1.9.1
>