linux-kernel - RE: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Feb 2016 08:42:22 +0000
From:	Anil Gurumurthy <Anil.Gurumurthy@...gic.com>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Denys Vlasenko <dvlasenk@...hat.com>
CC:	James Bottomley <JBottomley@...allels.com>,
	Fabian Frederick <fabf@...net.be>,
	Christoph Hellwig <hch@....de>,
	Guenter Roeck <linux@...ck-us.net>,
	Ben Hutchings <ben@...adent.org.uk>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>
Subject: RE: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

You could remove the __bfa_trc32() routine

Thanks,
Acked-by: Anil Gurumurthy <anil.gurumurthy@...gic.com>

-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@...cle.com] 
Sent: 10 February 2016 22:59
To: Denys Vlasenko <dvlasenk@...hat.com>
Cc: James Bottomley <JBottomley@...allels.com>; Fabian Frederick <fabf@...net.be>; Anil Gurumurthy <Anil.Gurumurthy@...gic.com>; Christoph Hellwig <hch@....de>; Guenter Roeck <linux@...ck-us.net>; Ben Hutchings <ben@...adent.org.uk>; linux-kernel <linux-kernel@...r.kernel.org>; linux-scsi <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

>>>>> "Denys" == Denys Vlasenko <dvlasenk@...hat.com> writes:

Denys> __bfa_trc32() is very similar, so it is uninlined too.  However, 
Denys> it appears to be unused, therefore this patch ifdefs it out.

Why don't we just drop it?

-- 
Martin K. Petersen	Oracle Linux Engineering