linux-kernel - Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87oabnaah1.fsf@nemi.mork.no>
Date:	Thu, 11 Feb 2016 09:59:38 +0100
From:	Bjørn Mork <bjorn@...k.no>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Oliver Neukum <oneukum@...e.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Felipe Balbi <balbi@...nel.org>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	USB <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

Andy Shevchenko <andy.shevchenko@...il.com> writes:

> To me out: sounds out, like printing error and return code, or
> something like that. Here the case is different.
>
> And since we have two full switches it might be hard to have on one
> screen out code and exact goto. See my point now?

No, sorry.  Not really.

The pattern

   out:
      return whatever;

is so common in the kernel that I cannot see any point starting a
discussion about it:

 bjorn@...i:/usr/local/src/git/linux$ git grep -A1 ^out:|grep return|wc -l
 3622

And I also fail to see any relation between the explanation you come up
with here and the text in CodingStyle, which was what you initially
referred to.  There is no specific interpreation of the label name "out"
there AFAICS.

I apologize if you think I am being an ass now. I am.  I'm just too fed
up with coding style arguments with no other reason than a vague pointer
to some document.  If you're going to point out coding style problems,
then you could at least make an effort explaining why a style change
improves the code.  My bet is that most of the time you'll find that the
comment is unnecessary...

Bjørn